fix: handle nested partial select with left join when first column is null#5436
Open
Iceshen87 wants to merge 1 commit intodrizzle-team:mainfrom
Open
fix: handle nested partial select with left join when first column is null#5436Iceshen87 wants to merge 1 commit intodrizzle-team:mainfrom
Iceshen87 wants to merge 1 commit intodrizzle-team:mainfrom
Conversation
… null - Fix bug where entire nested object becomes null if first field is null - Track individual field nullability instead of object-level - Only nullify nested object if ALL fields are null AND join is nullable - Add comprehensive test coverage for edge cases Fixes: drizzle-team#1603
Author
|
Hi! Thanks for reviewing this PR. I noticed it doesn't have a bounty label. Does Drizzle ORM offer bounties for bug fixes? If so, could you please add the appropriate bounty label? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug #1603 where nested partial select returns null for the entire object when the first column value is null in a left join.
Bug
When using
.leftJoin()with nested object selection, if the first field in the nested object is null, the entire object returns null instead of containing the actual field values.Root Cause
The
nullifyMaplogic inutils.tswas tracking object-level nullability based on the first field encountered. If the first field was null, it marked the entire object for nullification.Solution
Changed
nullifyMapto track individual field nullability:{ tableName: string, hasNonNullValue: boolean }Testing
Related
/claim #1603 for Algora bounty