skip rename prompts during push --force#5460
Open
masad-frost wants to merge 2 commits intodrizzle-team:mainfrom
Open
skip rename prompts during push --force#5460masad-frost wants to merge 2 commits intodrizzle-team:mainfrom
masad-frost wants to merge 2 commits intodrizzle-team:mainfrom
Conversation
The --force flag was only suppressing data-loss and strict confirmation prompts but not the rename-resolution prompts (tables, columns, schemas, enums, sequences, views, policies, roles). This meant push --force would still block on interactive input when the schema diff had ambiguous renames. Thread the force flag through prepare*Push into the prompt functions so they early-return with delete-and-create instead of prompting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The --force flag was only suppressing data-loss and strict confirmation prompts but not the rename-resolution prompts (tables, columns, schemas, enums, sequences, views, policies, roles). This meant push --force would still block on interactive input when the schema diff had ambiguous renames. Thread the force flag through prepare*Push into the prompt functions so they early-return with delete-and-create instead of prompting.