Fix TypeError in slcan.py when formatting standard (non-extended) CAN…#89
Open
andrejrcarvalho wants to merge 1 commit intodronecan:masterfrom
Open
Fix TypeError in slcan.py when formatting standard (non-extended) CAN…#89andrejrcarvalho wants to merge 1 commit intodronecan:masterfrom
andrejrcarvalho wants to merge 1 commit intodronecan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix a type error on the _send_frame function of the slcan.py driver.

I found this bug while using the Jupyter console of the Dronecan GUI app:
After some tinkering with the pydronecan module, I've found that the
markervariable was being put in the wrong place when we try to send a standard frame (11 bit identifier) in the following function of theTxWorker: