Open
Conversation
2. Cherry pick the changes for using local dsdl repo
…llback is called after the node ID is allocated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1. Allow the DNA server to allocate NodeIDs endlessly
feature/ExtraPacketParse
2. Fix an annoying exception in ArrayValue::clear function
…ayValue which didn't define __iter__()
Replace os.getppid()!=parent_pid parent-death detection with multiprocessing.parent_process().sentinel wait when available. This prevents the MAVCAN IO subprocess from exiting unexpectedly, which caused nodes to appear/disappear sporadically
Document that reliable parent process death detection depends on multiprocessing.parent_process() (Python 3.8+). On Windows with Python 3.7, parent_process() is unavailable and the os.getppid() fallback is intentionally disabled, so detection is effectively unavailable. Add a runtime warning to recommend Python 3.8+ on Windows.
Only import/use multiprocessing.connection.wait when parent_sentinel is available. Change fallback gate from mp_wait is None to parent_sentinel is None on non-Windows platforms. Fixes a regression where POSIX Python 3.7 could skip both sentinel and os.getppid() parent-death detection paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.