Expose -IncludeHidden parameter#495
Draft
gaelicWizard wants to merge 5 commits intodsccommunity:mainfrom
Draft
Conversation
5b92e69 to
e7848d9
Compare
NetAdapter module Cmdlets have an -IncludeHidden flag which allows access to adapters which are hidden; expose that flag here. - Add flag to MOF schemas - Add function parameter and comment based help - NetAdapterName should now be working - NetAdapterRdma should now be working - NetAdapterRss should now be working - NetAdapterState should now be working
e7848d9 to
bad0489
Compare
Add [Switch]IncludeHidden to mocked Rename-NetAdapter in unit tests
Add [Switch]IncludeHidden to mocked Set-NetAdapterRdma in unit tests
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
===================================
Coverage 97% 97%
===================================
Files 28 28
Lines 2070 2071 +1
===================================
+ Hits 2021 2023 +2
+ Misses 49 48 -1
🚀 New features to boost your workflow:
|
Member
|
@gaelicWizard - this is quite an interesting one. Could you raise an issue for us to discuss it? What I'd like to think about (and open for discussion) is should we just switch the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
NetAdapter module Cmdlets have an -IncludeHidden flag which allows access to adapters which are hidden; expose that flag here.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is