Draft
Conversation
jesteria
commented
May 9, 2019
Member
Author
jesteria
left a comment
jesteria
left a comment
There was a problem hiding this comment.
looks like nice clean-up to me
| import testing.postgresql | ||
|
|
||
|
|
||
| def test_save_experiment_and_get_hash(): |
Member
Author
There was a problem hiding this comment.
unclear to me how much of this is being moved around – (all of it?) – versus new code; so, keep that in mind.
but, for one, any reason not to use the fixtures, e.g. db_engine?
Contributor
There was a problem hiding this comment.
all of it's being moved around. These mostly predate the fixtures, so they can be refactored but that wasn't the focus of this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is @thcrock's PR. He can do what he likes with it!