Skip to content

Add missing job status change event for scaling #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvstme wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing job status change event for scaling #3465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/dstack/_internal/server/services/runs/replicas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ async def scale_run_replicas(session: AsyncSession, run_model: RunModel, replica
)

# lists of (importance, is_out_of_date, replica_num, jobs)
active_replicas = []
inactive_replicas = []
active_replicas: list[tuple[int, bool, int, list[JobModel]]] = []
inactive_replicas: list[tuple[int, bool, int, list[JobModel]]] = []

for replica_num, replica_jobs in group_jobs_by_replica_latest(run_model.jobs):
statuses = set(job.status for job in replica_jobs)
Expand Down Expand Up @@ -108,8 +108,8 @@ async def scale_run_replicas(session: AsyncSession, run_model: RunModel, replica
for job in replica_jobs:
if job.status.is_finished() or job.status == JobStatus.TERMINATING:
continue
job.status = JobStatus.TERMINATING
job.termination_reason = JobTerminationReason.SCALED_DOWN
switch_job_status(session, job, JobStatus.TERMINATING, events.SystemActor())
# background task will process the job later
else:
scheduled_replicas = 0
Expand Down