Provide per-bundle oauth2 auth configuration #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting authentication configuration per service in the `config.json`, SPAS can now take an object specified in bundle's `auth.provider` besides string name. For oauth2, the configuration object's keys are: * `baseSite` * `authorizePath` * `accessTokenPath` * `client_id` * `client_secret`
lib/oauth2.js
Outdated
Contributor
Author
There was a problem hiding this comment.
This is the only significant change (same as line 72), the rest are just re-indentation.
Owner
|
I think this style is hard to read. Also we can use built in Javascript methods by testing the other way. negating the need for _ here. |
Contributor
Author
|
I have made adjustments per your comment. Also updated oauth.js. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting authentication configuration per service in the
config.json, SPAS can now take an object specified in bundle'sauth.providerbesides string name.For oauth2, the configuration object's keys are:
baseSiteauthorizePathaccessTokenPathclient_idclient_secret