Fix manager refreshing bundle #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer version of `fs.readdirSync` does not return `.` or `..` and thus excluding the changed bundle from its list. This commit simply makes the temporary file readable by `fs.readdirSync` so that bundle manager can reload it correctly. Now that we don't have `.` file when reading the bundle folder, I removed the last condition, but there may be a reason for it. Let me know if that is the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of
fs.readdirSyncdoes not return.or..and thus excluding the changed bundle from its list. This commit simply makes the temporary file readable byfs.readdirSyncso that bundle manager can reload it correctly.Now that we don't have
.file when reading the bundle folder, I removed the last condition, but there may be a reason for it. Let me know if that is the case.