Switching logging to Bunyan #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 14, 2015 09:48
- Custom levels (`event`, `verbose`) are aliased. - Add tests for logging levels using vows. - Add npm scripts: `npm start` and `npm test`
Add Bunyan's `Logger.prototype.event` instead of `event` function on the logger instance.
Child loggers can contain `bid`, `key`, `ip`, `override` fields so that any log calls will include them. This can help when aggregating logs.
Owner
This is exactly what I was thinking we could do. Thank you for this. Charlie's a friend but he hasn't been keeping up with Winston so time to move on. |
Requires setting environment variables `LOG_TOKEN` and `LOG_SUBDOMAIN" (optional), i.e.: ``` LOG_TOKEN=xxxxxxxx LOG_SUBDOMAIN=spas node spas --dev --log=verbose ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an open pull request, as I will need feedbacks and suggestions until it's completed to close. Currently it has:
bunyaninstead ofwinston.bid,key,ip,overridefields depending on where the logger is called.I tried to look for a way to calculate bandwidth but it seems to requires we use
netinstead ofhttpfor server since it needs to readbytesReceivedandbytesSent. Therefore, I figure we can use services like Loggy to aggregate logs and look at accumulated responses' size and use it as data usage.In Loggy, I could perform a search like this to see data usage: