Skip to content

Parent in result of to_params for instances of has_many #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dturnerTS wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Parent in result of to_params for instances of has_many #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions spec/model/associations_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
builder.use Her::Middleware::FirstLevelParseJSON
builder.use Faraday::Request::UrlEncoded
builder.adapter :test do |stub|
stub.get("/users/1") { |env| [200, {}, { :id => 1, :name => "Tobias Fünke", :comments => [{ :comment => { :id => 2, :body => "Tobias, you blow hard!", :user_id => 1 } }, { :comment => { :id => 3, :body => "I wouldn't mind kissing that man between the cheeks, so to speak", :user_id => 1 } }], :role => { :id => 1, :body => "Admin" }, :organization => { :id => 1, :name => "Bluth Company" }, :organization_id => 1 }.to_json] }
stub.get("/users/1") { |env| [200, {}, { :id => 1, :name => "Tobias Fünke", :comments => [{ :comment => { :id => 2, :body => "Tobias, you blow hard!", :user_id => 1 } }, { :comment => { :id => 3, :body => "I wouldn't mind kissing that man between the cheeks, so to speak", :user_id => 1 } }], :role => { :id => 1, :body => "Admin" }, :organization => { :id => 1, :name => "Bluth Company" }, :organization_id => 1, bars: [{ id: 41}] }.to_json] }
stub.get("/users/2") { |env| [200, {}, { :id => 2, :name => "Lindsay Fünke", :organization_id => 2 }.to_json] }
stub.get("/users/1/comments") { |env| [200, {}, [{ :comment => { :id => 4, :body => "They're having a FIRESALE?" } }].to_json] }
stub.get("/users/2/comments") { |env| [200, {}, [{ :comment => { :id => 4, :body => "They're having a FIRESALE?" } }, { :comment => { :id => 5, :body => "Is this the tiny town from Footloose?" } }].to_json] }
Expand All @@ -112,6 +112,7 @@

spawn_model "Foo::User" do
has_many :comments, class_name: "Foo::Comment"
has_many :bars, class_name: "Foo::Bar"
has_one :role
belongs_to :organization
has_many :posts, :inverse_of => :admin
Expand All @@ -128,6 +129,10 @@
parse_root_in_json true
end

spawn_model "Foo::Bar" do
parse_root_in_json true
end

spawn_model "Foo::Role"

@user_with_included_data = Foo::User.find(1)
Expand Down Expand Up @@ -228,6 +233,11 @@
params[:comments].length.should eq(2)
end

it "doesn't includes parent when calling to_params on a has_many relationships" do
bars_params = @user_with_included_data.bars.first.to_params
bars_params.keys.should_not include(:user)
end

[:create, :save_existing, :destroy].each do |type|
context "after #{type}" do
let(:subject) { self.send("user_with_included_data_after_#{type}")}
Expand Down Expand Up @@ -290,7 +300,7 @@
@user_without_included_data.company.name.should == "Bluth Company"
end

it "does not require foreugn key to have nested object" do
it "does not require foreign key to have nested object" do
@user_with_included_data_but_no_fk.company.name.should == "Bluth Company Inc."
end
end
Expand Down