Open
Conversation
This PR updates submodules and adds a number of minor changes: - update `duckdb` submodule to the latest `v1.5-variegata` - update `extension-ci-tools` submodule to the latest `main` - update `MainDistributionPipeline.yml` to the same versions of the engine and CI tools as above - update `Linux.yml` to set `LOCAL_EXTENSION_REPO` env var that is now (after some recent `unittest` chage) is required to run tests with extensions that are not statically linked (otherwise `require postgres_scanner` fails) - apply patch `getdatainternal.patch` from the engine repo - add a change to `postgres_storage.cpp` to accomodate to changes added in duckdb/duckdb#20508 - update `attach_types.test` that started failing due to duckdb/duckdb#20361 change PS: due to changes required for duckdb/duckdb#20508 it is suggested to add `v1.4-andium` branch to this repo (on a current `main`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates submodules and adds a number of minor changes:
duckdbsubmodule to the latestv1.5-variegataextension-ci-toolssubmodule to the latestmainMainDistributionPipeline.ymlto the same versions of the engine and CI tools as aboveLinux.ymlto setLOCAL_EXTENSION_REPOenv var that is now (after some recentunittestchage) is required to run tests with extensions that are not statically linked (otherwiserequire postgres_scannerfails)getdatainternal.patchfrom the engine repopostgres_storage.cppto accomodate to changes added in Settings Rework: Move many more settings to the generic settings and extend functionality/speed up retrieval duckdb#20508attach_types.testthat started failing due to TIME_NS Support + Arrow duckdb#20361 changePS: due to changes required for duckdb/duckdb#20508 it is suggested to add
v1.4-andiumbranch to this repo (on a currentmain).