Add support for new geometry type instead of relying on spatial#406
Merged
pdet merged 3 commits intoduckdb:mainfrom Feb 24, 2026
Merged
Add support for new geometry type instead of relying on spatial#406pdet merged 3 commits intoduckdb:mainfrom
pdet merged 3 commits intoduckdb:mainfrom
Conversation
Contributor
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for converting then new
GEOMETRYtype in DuckDB v1.5 back and forth seamlessly to PostGIS.This is much nicer and has less sharp edges than the previous "cast to intermediate wkb_blob type that spatial understands"-based solution. The test no longer requires spatial.
I've added support for the correct conversion when reading/writing both for the binary and text protocol (I don't think the text format actually worked previously).
In the future we should propagate coordinate system information by peeking through the PostGIS metadata tables, but I will leave that for a follow-up PR as that requires more complex metadata management instead of just conversion code.