Fix SQLiteInsert to use casted plan instead of raw plan#157
Merged
Mytherin merged 1 commit intoduckdb:mainfrom Sep 2, 2025
Merged
Fix SQLiteInsert to use casted plan instead of raw plan#157Mytherin merged 1 commit intoduckdb:mainfrom
Mytherin merged 1 commit intoduckdb:mainfrom
Conversation
56a66f2 to
801922e
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appears to be an issue where SQLiteInsert uses the raw plan instead of the type-casted plan. The code calls AddCastToSQLiteTypes to create inner_plan but then uses the original plan: