You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the PR!
In order to update the report I ask authors to run the benchmark themselves on a c6id.metal and report the updates to the time.csv and logs.csv files as well. In order to make sure everything works as is though, you can wait until the regression tests pass.
Can you also add modin to the solution-matrix in the regression.yml file? That way it will get automatically tested
Thanks for the PR! In order to update the report I ask authors to run the benchmark themselves on a c6id.metal and report the updates to the time.csv and logs.csv files as well. In order to make sure everything works as is though, you can wait until the regression tests pass.
Can you also add modin to the solution-matrix in the regression.yml file? That way it will get automatically tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables modin backend, which was part of the original H2O benchmark. If something is missing don't hesitate to contact me to fix the issue.