Skip to content

Fix pixel definition for free-trial-conversion wide event #7426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nalcalag wants to merge 2 commits into
base: develop
Choose a base branch
from
+8 −4
Open

Fix pixel definition for free-trial-conversion wide event #7426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
489ea9e
Fix pixel definition
nalcalag Dec 22, 2025
b4bbf94
Added sandbox plans
nalcalag Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions PixelDefinitions/pixels/wide_free_trial_conversion.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,14 @@
"key": "feature.data.ext.free_trial_plan",
"description": "The base plan ID of the free trial product activated",
"enum": [
"ddg.privacy.pro.monthly.renews.us",
"ddg-privacy.pro.monthly.renews.us",
"ddg.privacy.pro.monthly.renews.row",
"ddg.privacy.pro.yearly.renews.us",
"ddg.privacy.pro.yearly.renews.row"
"ddg.privacy.pro.yearly.renews.row",
"ddg-privacy.pro.sandbox.monthly.renews.us",
"ddg.privacy.pro.sandbox.monthly.renews.row",
"ddg.privacy.pro.sandbox.yearly.renews.us",
"ddg.privacy.pro.sandbox.yearly.renews.row"
Copy link

@cursor cursor bot Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent plan ID prefix between monthly and yearly plans

The plan ID naming shows an inconsistency after this change. Only US monthly plans use the ddg-privacy prefix (with hyphen), while US yearly plans still use ddg.privacy (with dot). Specifically, ddg-privacy.pro.monthly.renews.us and ddg-privacy.pro.sandbox.monthly.renews.us use hyphen, but ddg.privacy.pro.yearly.renews.us and ddg.privacy.pro.sandbox.yearly.renews.us use dot. If the fix to use hyphen is correct for monthly plans, the yearly US plans may need the same update.

Fix in Cursor Fix in Web

Copy link
Contributor

@lmac012 lmac012 Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nalcalag shouldn't all of these use hyphens instead of dots as separators? I assume values should match what we have in SubscriptionConstants.kt:

    // List of plans
    const val YEARLY_PLAN_US = "ddg-privacy-pro-yearly-renews-us"
    const val MONTHLY_PLAN_US = "ddg-privacy-pro-monthly-renews-us"
    const val YEARLY_PLAN_ROW = "ddg-privacy-pro-yearly-renews-row"
    const val MONTHLY_PLAN_ROW = "ddg-privacy-pro-monthly-renews-row"

]
},
{
Expand All @@ -36,12 +40,12 @@
"enum": ["expired", "timeout"]
},
{
"key": "feature.data.ext.step.vpn_activated_d1.success",
"key": "feature.data.ext.step.vpn_activated_d1",
"description": "true if VPN was successfully activated within first day of Free Trial",
"enum": ["true", "false"]
},
{
"key": "feature.data.ext.step.vpn_activated_d2_to_d7.success",
"key": "feature.data.ext.step.vpn_activated_d2_to_d7",
"description": "true if VPN was successfully activated between D2-D7 of Free Trial",
"enum": ["true", "false"]
}
Expand Down
Loading