feat: add gradle wrapper #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for filing this issue! The wrapper was already included in the repo though... if you go to the code in the repo you'll see the gradle/wrapper folder and its contents.., Cheers, |
Contributor
Author
|
True, the intent was so people could run it directly without having to go through the parent. (or just download the zipped folder) |
Owner
|
That makes sense the problem is that we'd have 2 copies of gradle wrapper and I think that could cause problems (versions getting out of sync, etc)... Perhaps we could have in the README an example on how to run a demo using gradle? |
Contributor
Author
|
Also an option, or maybe make the demo a standalone repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have the wrapper for people that have a newer version of Gradle installed given the current project setup