Added Upload feature / Added more SQL Insert and update method to mak…#1
Conversation
durlabhjain
requested changes
Dec 7, 2021
lib/sql.js
Outdated
Owner
There was a problem hiding this comment.
Do a pull first. It seems a lot of code with similar functionality was already added in the master branch
lib/util.js
Outdated
Owner
There was a problem hiding this comment.
Why do we have hard-coded credentials committed?
lib/util.js
Outdated
Owner
There was a problem hiding this comment.
We can use have buildFormData or jsonToFormData with signature:
buildFormData: function(data, formData = new FormData(), parentKey)
Owner
|
Rejected as most changes are now in the main branch. Let me know if we still need it. |
durlabhjain
pushed a commit
that referenced
this pull request
Mar 6, 2024
Enhancement: Elastic Search Backend Changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e easy requests