Skip to content
This repository was archived by the owner on Dec 4, 2024. It is now read-only.

WIP: Factoring with CQM#22

Open
mhlr wants to merge 1 commit intodwave-examples:masterfrom
mhlr:cqm
Open

WIP: Factoring with CQM#22
mhlr wants to merge 1 commit intodwave-examples:masterfrom
mhlr:cqm

Conversation

@mhlr
Copy link

@mhlr mhlr commented Jan 14, 2022

Currently this is a script. I can either work it into the existing notebook or create a new notebook

@mhlr mhlr requested a review from JoelPasvolsky as a code owner January 14, 2022 04:03
@mhlr
Copy link
Author

mhlr commented Jan 14, 2022

@JoelPasvolsky Would it be better to add this to the existing notebook or create a new one?
Also any idea what the CI failures are about? They seem to be complaining abot the notebook, but i did not touch that.

@JoelPasvolsky
Copy link
Collaborator

@mhlr, don't worry about the CI failures. I think the first question is whether to bring some of these functions into dimod. If so, the code will be short and could make a nice appendix to the current JN; otherwise perhaps a second one.

@mhlr
Copy link
Author

mhlr commented Jan 14, 2022

I think the first question is whether to bring some of these functions into dimod

Would that be a gates module for the CQM? Might make sense to put it all here first and refactor/move to dimod later.

@arcondello
Copy link
Contributor

I would be inclined to put them here rather than in dimod for now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants