Add effective sample size estimators#1414
Open
kevinchern wants to merge 9 commits intodwavesystems:mainfrom
Open
Add effective sample size estimators#1414kevinchern wants to merge 9 commits intodwavesystems:mainfrom
kevinchern wants to merge 9 commits intodwavesystems:mainfrom
Conversation
kevinchern
commented
Feb 19, 2026
thisac
reviewed
Feb 23, 2026
Co-authored-by: Radomir Stevanovic <radomir.stevanovic@gmail.com>
pau557
suggested changes
Feb 27, 2026
Contributor
pau557
left a comment
pau557
left a comment
There was a problem hiding this comment.
This looks good so far, but I would add more contextual elements
- Time steps are mentioned in the definition of the x argument, but not in the text body. It should be clear what these time steps represent.
- Similarly, what are the elements of the matrix? We know that they were generated in independent Markov chains at different time steps, but we don’t know what they are. Is it an aggregation metric?
I suggest a practical intuitive example of how this method is expected to be used within the context of dimod samplers.
And I think that it would be great to include an API that accepts dimod samplesets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add effective sample size estimators based on Revisiting the Gelman-Rubin Diagnostic