Remove ObjectManager and Fix DataTargetRepository DI#17
Open
brannow wants to merge 8 commits intodwenzel:developfrom
Open
Remove ObjectManager and Fix DataTargetRepository DI#17brannow wants to merge 8 commits intodwenzel:developfrom
brannow wants to merge 8 commits intodwenzel:developfrom
Conversation
Remove ObjectManager from Typo3v12 Version
use DI injection for the DataRepo
use setter for targetClass so we use DI for that class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Little fix that remove the DataTargetRepository ObjectManager usage (this didn't exists in Typo3v12 anymore)
also use DI for the DataTargetRepository, to deal with the needed TargetClass, i'll at a setTargetClass and use it in the factory as a quickfix.