Feature: HTML editor #59
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Basic changes to Stimulus controller - Integrated placeholder area for HTML editor
- Implemented entire functionality of HTML editor
- Chat area and HTML editor area now switch visibility when activated
- Close/open animation of chat area and HTML editor area now smoothly animated
manuelkiessling
commented
Feb 3, 2026
src/ChatBasedContentEditor/Presentation/Controller/ChatBasedContentEditorController.php
Outdated
Show resolved
Hide resolved
manuelkiessling
commented
Feb 3, 2026
src/ChatBasedContentEditor/Presentation/Controller/ChatBasedContentEditorController.php
Outdated
Show resolved
Hide resolved
manuelkiessling
commented
Feb 3, 2026
| const editLink = document.createElement("a"); | ||
| editLink.href = "#"; | ||
| editLink.className = | ||
| "text-dark-500 hover:text-primary-600 dark:text-dark-400 dark:hover:text-primary-400 transition-colors"; |
Member
Author
There was a problem hiding this comment.
Make sure this doesn't reinvent link styling with low-level Tailwind if ready-made styles for this exist in the webui Living Styleguide.
manuelkiessling
commented
Feb 3, 2026
| loadError: 'editor.html_editor_load_error'|trans | ||
| } | ||
| }) }} | ||
| data-action="html-editor:open->html-editor#openEditor" |
Member
Author
There was a problem hiding this comment.
I think this could be written as stimulus_action (see Symfony UX Twig Components / Stimulus Bridge documentation), but might not work for non-default Stimulus actions.
manuelkiessling
commented
Feb 3, 2026
Member
Author
manuelkiessling
left a comment
manuelkiessling
left a comment
There was a problem hiding this comment.
Looks good, but definitely needs some tests, at least unit and frontend.
- Hartkodierten Teilpfad entfernt
- Used an icon from Heroicons for 'edit'
- Added new class for icon links from WebUI bundle
- Added tests for HTML editor
…versation: - Tests, later submitted
…versation: - Fixed erroneous test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.