Add support for Arcanist .arcrc configuration files #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users who already use Arcanist have credentials stored in ~/.arcrc. This change allows phabfive to read PHAB_URL and PHAB_TOKEN from that file, making it easier for Arcanist users to get started. Features: - Security check ensures config files have 0600 permissions before reading (applies to ~/.config/phabfive.yaml, ~/.config/phabfive.d/*.yaml, ~/.arcrc) - Single host in .arcrc: automatically uses both URL and token - Multiple hosts in .arcrc: requires PHAB_URL to be set to select which host - URL matching normalizes trailing slashes for reliable matching Closes #123 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When multiple hosts are configured in .arcrc, use the config.default field to select which host to use (if no PHAB_URL is explicitly set). Priority order: 1. PHAB_URL from env/config (highest) 2. config.default from .arcrc 3. Single host in .arcrc (auto-select) 4. Multiple hosts without default (error with list) Also fixed _normalize_url to properly handle URLs without /api/ suffix (e.g., https://example.com -> https://example.com/api/). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When multiple hosts are configured in .arcrc, use the config.default field to select which host to use (if no PHAB_URL is explicitly set). Priority order: 1. PHAB_URL from env/config (highest) 2. config.default from .arcrc 3. Single host in .arcrc (auto-select) 4. Multiple hosts without default (error with list) Also fixed _normalize_url to properly handle URLs without /api/ suffix (e.g., https://phorge.example.com -> https://phorge.example.com/api/). Standardized example hostnames to use phorge.example.com. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
holmboe
force-pushed
the
fix/issue-123-arcrc-file
branch
from
4a1230f to
85b5aed
Compare
Windows uses ACLs instead of Unix-style permissions, so os.chmod() and the permission bits from os.stat() don't work as expected. - Skip _check_secure_permissions() on Windows (os.name == "nt") - Skip permission-related tests on Windows with pytest.mark.skipif Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
~/.arcrcfile, making it easier for existing Arcanist users to get started with phabfiveconfig.defaultfield in.arcrcto select the default host when multiple hosts are configured.arcrcby requiringPHAB_URLto be set when more than one host is configured and no default is specifiedFeatures
.arcrcsupport: Automatically readsPHAB_URLandPHAB_TOKENfrom~/.arcrcif presentconfig.default→ uses the default hostPHAB_URLto select which hostPHAB_URLfrom env/config (highest)config.defaultfrom.arcrc.arcrc(auto-select)~/.config/phabfive.yaml,~/.config/phabfive.d/*.yaml, and~/.arcrchave secure permissions (not readable by group/others)/api/suffixTest plan
_check_secure_permissions).arcrcloading with various permission modesconfig.defaulthandlingCloses #123
🤖 Generated with Claude Code