Refactor: Improve code organization and naming #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move task display functions to cli.py (display_task_rich, display_task_tree,
display_task_strict, display_tasks)
- Rename print methods to getter methods across modules:
- diffusion: print_uri -> get_uris_formatted, print_repositories ->
get_repositories_formatted, print_branches -> get_branches_formatted
- paste: print_pastes -> get_pastes_formatted
- user: print_whoami -> get_whoami
- passphrase: remove print_secret, use get_secret directly
- maniphest: _format_and_display_tasks -> _build_task_display_data
- CLI now handles all output formatting and printing
- Library modules return data structures instead of printing directly
This separation improves testability and allows library code to be
used programmatically without side effects.
Split maniphest.py (3,317 lines) into focused submodules: - core.py: Main Maniphest class orchestrator - utils.py: Utility functions (timestamps, variable rendering) - validators.py: Input validation - resolvers.py: PHID resolution - fetchers.py: API data fetching - filters.py: Task filtering - formatters.py: Data formatting - Remove underscore prefix from utility functions now at module level - Update test imports to use new package structure - Maintain backward compatibility via __init__.py re-exports
Change from generic API message to actionable:
"Access denied, visit {url}/K{id} to allow Conduit"
- create_task_cli -> create_task (not CLI-specific) - create_from_config -> create_tasks_from_yaml (more specific) - get_whoami -> whoami (cleaner API) - add_comment -> add_task_comment (more specific) - info -> get_task_info (was too vague) - days_to_unix -> days_ago_to_timestamp (clearer intent) - _load_search_from_yaml -> _load_search_config (simpler)
Timpan4
approved these changes
Jan 12, 2026
Contributor
Timpan4
left a comment
Timpan4
left a comment
There was a problem hiding this comment.
lgtm! real nice. was needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the codebase for better maintainability and clearer APIs.
Changes
1. Move display logic from library to CLI (
47b3052)print_uri→get_uris_formatted, etc.print_pastes→get_pastes_formattedprint_whoami→get_whoamiprint_secret, useget_secretdirectly2. Convert maniphest.py to package structure (
ffa4e6c)core.py: Main Maniphest class orchestratorutils.py: Utility functionsvalidators.py: Input validationresolvers.py: PHID resolutionfetchers.py: API data fetchingfilters.py: Task filteringformatters.py: Data formatting__init__.pyre-exports3. Improve Conduit access denied error message (
3df5a42)Access denied, visit {url}/K{id} to allow Conduit4. Improve method naming (
c7a2bd6)create_task_cli→create_taskcreate_from_config→create_tasks_from_yamlget_whoami→whoamiadd_comment→add_task_commentinfo→get_task_infodays_to_unix→days_ago_to_timestamp_load_search_from_yaml→_load_search_configTesting
All 257 tests pass.