Skip to content

Improve error messages for --status, --priority and --column filters #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
holmboe merged 3 commits into from
Jan 21, 2026
Merged

Improve error messages for --status, --priority and --column filters #127

holmboe merged 3 commits into from
Jan 21, 2026
+116 −88

Conversation

@holmboe
Copy link
Contributor

@holmboe holmboe commented Jan 21, 2026

Summary

  • Add helpful error messages when filter patterns have invalid syntax, showing expected format and valid types
  • Rename maniphest_transitions.py to column_transitions.py for clarity
  • Rename TransitionPattern to ColumnPattern for consistency with StatusPattern and PriorityPattern
  • Add constants for valid condition types, keywords, and directions in each transition module

Before

ERROR: Invalid status filter pattern: Invalid status condition syntax: 'Done'

After

ERROR: Invalid status filter pattern: Invalid status condition syntax: 'Done'. Expected format: TYPE:STATUS (e.g., 'in:Open', 'not:in:Done'). Valid types: from, to, in, been, never, raised, lowered

Test plan

  • All 262 tests pass
  • Verified error messages show valid types for --column, --status, and --priority

🤖 Generated with Claude Code

holmboe and others added 3 commits January 21, 2026 11:54
@holmboe
Give hints on valid syntax for --status, --priority and --column
a85cec9
@holmboe @claude
Rename TransitionPattern to ColumnPattern for consistency
4b6af13 
Rename throughout codebase for consistency with StatusPattern and
PriorityPattern naming:
- TransitionPattern -> ColumnPattern
- parse_transition_patterns -> parse_column_patterns
- transition_patterns variable -> column_patterns

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@holmboe
make lock
215299d
@holmboe holmboe requested a review from Timpan4 January 21, 2026 11:03
Timpan4
Timpan4 approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@Timpan4 Timpan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real clean!

@holmboe holmboe merged commit 7657115 into master Jan 21, 2026
15 checks passed
@holmboe holmboe deleted the error-with-suggestions branch January 21, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Timpan4 Timpan4 Timpan4 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@holmboe @Timpan4