fix: resolve three E2E test failures — TTS default, Telegram stop, browser VAD (#70)#75
Merged
fix: resolve three E2E test failures — TTS default, Telegram stop, browser VAD (#70)#75
Conversation
⚙️ Settings E2E Test Recording
Run #22023213377 | Commit f8845ba |
🎥 Browser E2E Test Recording
Run #22023213377 | Commit f8845ba |
🔔 Push Browser E2E Test Recording
Run #22023213377 | Commit f8845ba |
Root cause: updateSettings() did a shallow merge, so partial updates to
nested objects (stt, tts, talkMode) replaced the entire object instead of
merging. When enableVoiceFeatures() sent tts: {enabled, provider} without
endpoint/apiKey/voice/model/speed, Zod validation failed with 400 and
none of the settings (including STT) were updated.
Changes:
- Deep merge nested config objects in updateSettings() so partial updates
work correctly for stt, tts, talkMode, notifications, sessionPrune
- Enable STT by default (DEFAULT_STT_CONFIG.enabled = true) to match the
Whisper server auto-start behavior
- Log PATCH errors in enableVoiceFeatures() for debugging
- Skip TTS Synthesis test when Coqui server is not available (slim Docker)
⚙️ Settings E2E Test Recording
Run #22023463064 | Commit 362c5a6 |
🎥 Browser E2E Test Recording
Run #22023463064 | Commit 362c5a6 |
🔔 Push Browser E2E Test Recording
Run #22023463064 | Commit 362c5a6 |
In CI/headless Chrome, FCM preprod endpoints return 410 (Gone) causing webpush delivery to fail. The full pipeline still works (subscribe → store → attempt delivery), so the test now passes when the subscription was created and delivery was attempted, even if FCM rejected it.
⚙️ Settings E2E Test Recording
Run #22026174260 | Commit 3c4d676 |
🔔 Push Browser E2E Test Recording
Run #22026174260 | Commit 3c4d676 |
🎥 Browser E2E Test Recording
Run #22026174260 | Commit 3c4d676 |
…ondition Multiple parallel CI jobs push screencasts to the same test-assets branch. When they finish simultaneously, git push rejects due to remote having new commits from another job. This is cosmetic (not test results) so it should not fail the job.
⚙️ Settings E2E Test Recording
Run #22026309736 | Commit 7811bff |
🎥 Browser E2E Test Recording
Run #22026309736 | Commit 7811bff |
🔔 Push Browser E2E Test Recording
Run #22026309736 | Commit 7811bff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DEFAULT_TTS_CONFIG.enabled: true) so E2E tests don't fail on disabled TTSDEFAULT_STT_CONFIG.enabled: true) to match Whisper server auto-start behaviorupdateSettings()did a shallow merge, so partial updates to nested objects (stt, tts, talkMode) replaced the entire object. WhenenableVoiceFeatures()senttts: {enabled, provider}without endpoint/apiKey/voice/model/speed, Zod validation failed (400) and none of the settings were updated.enableVoiceFeatures()test helper for better debuggingbot.stop()in try/catch inTelegramProvider.stop()to prevent Grammy's finalgetUpdatescall from throwing on shutdownsource.loop = trueon Web Audio injection so audio plays continuously during browser E2E testsTesting Done
pnpm buildpassespnpm test)Issue
Closes #70