fix: make question widget options clickable inline (#79)#80
Merged
Conversation
added 2 commits
February 14, 2026 16:37
…#79) - Transform inline question options from non-clickable <span> to interactive <button> elements - Add checkbox-style selection UI with submit/skip buttons and loading/error states - Add dismissDialog() to QuestionContext so X button hides dialog without rejecting on server - Handle question SSE events in session-level useSSE hook for reliable delivery - Add 47 tests across QuestionContext, QuestionDialog, and ToolCallPart
🔔 Push Browser E2E Test RecordingRun #22026915422 | Commit c04a403 |
🎥 Browser E2E Test RecordingRun #22026915422 | Commit c04a403 |
⚙️ Settings E2E Test RecordingRun #22026915422 | Commit c04a403 |
🔔 Push Browser E2E Test RecordingRun #22026945759 | Commit 99e6dc9 |
⚙️ Settings E2E Test RecordingRun #22026945759 | Commit 99e6dc9 |
🎥 Browser E2E Test RecordingRun #22026945759 | Commit 99e6dc9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Summary
ToolCallPart.tsx— options were rendered as non-clickable<span>elements, now they are interactive<button>elements with checkbox-style selection, submit/skip actions, and loading/error stateshandleReject()which rejected the question on the server; now callsdismissDialog()which only hides the dialog, letting users answer inline insteaduseSSEhook so events are not silently dropped when no repo-level SSE connection existsRoot Cause
The question widget had a dual rendering architecture with a critical disconnect:
ToolCallPart.tsx) were non-clickable<span>elements that just showed "Click the dialog to respond"QuestionDialogdepended on receiving aquestion.askedSSE event viaPermissionContext, but this SSE connection only existed for repos with cached session queries — if no connection existed, the event was silently dropped and the dialog never appearedChanges
ToolCallPart.tsxuseQuestionContext()QuestionContext.tsxdismissDialog(),isDialogDismissedstate; new questions reset dismissed stateQuestionDialog.tsxisDialogDismissedtypes.tsSSEQuestionAskedEvent,SSEQuestionRepliedEvent,SSEQuestionRejectedEventtypesuseSSE.tsQuestionContext.test.tsxQuestionDialog.test.tsxToolCallPart.test.tsxTesting Done
cd frontend && npm run build— no TypeScript errorscd frontend && npx vitest run)Issue
Closes #79