Skip to content

I've rearranged the SerialNumber characteristic and set it to this.name #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cronjevh wants to merge 3 commits into
base: master
Choose a base branch
from
Open

I've rearranged the SerialNumber characteristic and set it to this.name #39

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9cd4753
use names for serial numbers
cronjevh Dec 3, 2021
e80d1e6
fix spacing
Dec 3, 2021
ea92564
use name for serial for garage too
Dec 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,14 +1460,15 @@ ParadoxAccessory.prototype.initService = function () {

this.informationService
.setCharacteristic(Characteristic.Manufacturer, 'Paradox')
.setCharacteristic(Characteristic.SerialNumber, 'Platform')
// .setCharacteristic(Characteristic.SerialNumber, 'Platform')
.setCharacteristic(Characteristic.FirmwareRevision, 'v1.0');

switch (this.config.type) {
case 'Alarm':
this.securitysystemService = new Service.SecuritySystem(this.name);
this.informationService
.setCharacteristic(Characteristic.Model, 'Alarm');
.setCharacteristic(Characteristic.Model, 'Alarm')
.setCharacteristic(Characteristic.SerialNumber, 'Platform');
this.securitysystemService
.getCharacteristic(Characteristic.SecuritySystemCurrentState)
.on('get', this.getAlarmState.bind(this));
Expand All @@ -1483,7 +1484,8 @@ ParadoxAccessory.prototype.initService = function () {
case 'Garage Door':
this.garagedooropenerService = new Service.GarageDoorOpener(this.name);
this.informationService
.setCharacteristic(Characteristic.Model, 'Garage Door');
.setCharacteristic(Characteristic.Model, 'Garage Door')
.setCharacteristic(Characteristic.SerialNumber, this.name);
this.garagedooropenerService
.getCharacteristic(DoorState)
.on('get', this.getDoorState.bind(this));
Expand Down Expand Up @@ -1512,12 +1514,14 @@ ParadoxAccessory.prototype.initService = function () {
case 'Contact Sensor':
this.contactsensorService = new Service.ContactSensor(this.name);
this.informationService
.setCharacteristic(Characteristic.Model, 'Contact Sensor');
.setCharacteristic(Characteristic.Model, 'Contact Sensor')
.setCharacteristic(Characteristic.SerialNumber, this.name);
break;
case 'Motion Sensor':
this.motionsensorService = new Service.MotionSensor(this.name);
this.informationService
.setCharacteristic(Characteristic.Model, 'Motion Sensor');
.setCharacteristic(Characteristic.Model, 'Motion Sensor')
.setCharacteristic(Characteristic.SerialNumber, this.name);
break;
case 'Smoke Sensor':
this.smokesensorService = new Service.SmokeSensor(this.name);
Expand Down