Fix time formatting bug in TableCondition #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-vo
reviewed
Jun 9, 2025
Comment on lines
+104
to
+106
| $reflection = new \ReflectionClass(TableCondition::class); | ||
| $method = $reflection->getMethod('buildQuery'); | ||
| $method->setAccessible(true); |
Collaborator
There was a problem hiding this comment.
You should not test private methods that are an implementation detail.
m-vo
reviewed
Jun 9, 2025
| $timeComparisonSql = 'CONCAT(DATE('.$timeComparisonSql.'), ?)'; | ||
|
|
||
| $params[] = ' '.date('H:m:s', (int) $trigger->cnd_table_executionTime); | ||
| $params[] = ' '.date('H:i:s', (int) $trigger->cnd_table_executionTime); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
phpunit --configuration phpunit.xml.dist(fails: command not found)https://chatgpt.com/codex/tasks/task_e_68430e0392708322a0f077119de5747c