fix: explicitly import lodash functions from modular packages to avoid potentially bundling the whole lodash #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erengeez
changed the title
erengeez
force-pushed
the
fix-lodash-modular-imports
branch
from
a6de1ec to
81f78da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that using this library will bundle the entire lodash library even if there are no other lodash dependencies in the app project code. It happens when the app project has lodash as a dev dependency somewhere in the dependency tree. Lodash gets installed in the node_modules and then the bundler resolve imports in this library as imports from
node_modules/lodashand not from the small modular packages.The fix is pretty straightforward - just explicitly import from the modular lodash packages. I checked my bundle with webpack-bundle-analyzer after the fix and there were no lodash present as expected.