chore: class cannot be final when lazy loaded#40
Merged
eFrane merged 1 commit intoeFrane:masterfrom Jan 13, 2025
Merged
Conversation
eFrane
approved these changes
Jan 13, 2025
Owner
eFrane
left a comment
eFrane
left a comment
There was a problem hiding this comment.
Yep, this doesn't have to be final. I vividly remember me being in my oh this should never need to be extended, I'm gonna put final on it era. Good catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current master branch throws an error during upgrade to symfony 6.4
Script cache:clear returned with error code 1
!!
!! In LazyServiceDumper.php line 138:
!!
!! Cannot generate lazy proxy for service "EFrane\PharBuilder\Development\Proc
!! ess\BoxProcessProvider".
!!
!!
!! In ProxyHelper.php line 92:
!!
!! Cannot generate lazy proxy: class "EFrane\PharBuilder\Development\Process\B
!! oxProcessProvider" is final.
!!
!!
Is there a need for BoxProcessProvider to be final?