Update Cdr.cpp: fix -Wconversion warning in options_[1] assignment#287
Open
rener2020 wants to merge 2 commits intoeProsima:masterfrom
Open
Update Cdr.cpp: fix -Wconversion warning in options_[1] assignment#287rener2020 wants to merge 2 commits intoeProsima:masterfrom
rener2020 wants to merge 2 commits intoeProsima:masterfrom
Conversation
fix(Cdr): silence -Wconversion warning when updating options_[1]
Explicitly cast arithmetic expression to uint8_t to prevent narrowing
conversion warning in GCC/Clang:
warning: conversion from ‘int’ to ‘std::array<unsigned char, 2>::value_type’ may change value [-Wconversion]
The new expression keeps the same semantics while ensuring type safety:
options_[1] = static_cast<uint8_t>(
static_cast<uint8_t>(options_[1] & 0xC) +
static_cast<uint8_t>(alignment & 0x3)
);
No behavioral change intended.
Signed-off-by: rener2020 <76736114+rener2020@users.noreply.github.com>
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(Cdr): silence -Wconversion warning when updating options_[1]
Explicitly cast arithmetic expression to uint8_t to prevent narrowing conversion warning in GCC/Clang:
The new expression keeps the same semantics while ensuring type safety:
No behavioral change intended.
Description
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist