DRAFT: DynamicDataHelper::print can print Sequences as well as Arrays#2827
Closed
willstott101 wants to merge 1 commit intoeProsima:masterfrom
Closed
DRAFT: DynamicDataHelper::print can print Sequences as well as Arrays#2827willstott101 wants to merge 1 commit intoeProsima:masterfrom
willstott101 wants to merge 1 commit intoeProsima:masterfrom
Conversation
927bb61 to
74e82a0
Compare
Signed-off-by: Will Stott <willstott101@gmail.com>
74e82a0 to
7c04c8d
Compare
Contributor
|
Is this still a draft? In the absence of tests for DynamicDataHelper, this would be very nice to get in for convenient printing of dynamic data I've tested the fix locally, and it fixes the issues as expected. |
13 tasks
Member
|
Closing in favor of #2957, where the changes here have been included |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sequence dynamic data types were indexed in the same way as fixed-length arrays in the DynamicDataHelper.
@Mergifyio backport (branch/2.7.x)
@Mergifyio backport (branch/2.6.x)
Maybe more...
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist
I'm leaving this as a draft until I've completed the extensive checklist... might be worth noting that I can't find any tests for this Helper at all atm - do I need to create some to get this merged?