Allow aliases in middlewares [12151] #158
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jparisu <javierparis@eprosima.com>
lauramg15
suggested changes
Jul 16, 2021
| else() | ||
| set(system_types ${_ARG_TYPES}) | ||
| endif() | ||
| message(STATUS "#! is_install_middleware_plugin called with aliases ${_ARG_ALIAS}") |
Contributor
There was a problem hiding this comment.
Suggested change
| message(STATUS "#! is_install_middleware_plugin called with aliases ${_ARG_ALIAS}") | |
| message(STATUS "The macro is_install_middleware_plugin is called for the middleware ${_ARG_MIDDLEWARE} with aliases ${_ARG_ALIAS}") |
jparisu
changed the title
jparisu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use aliases as names for
typesin every SH.Does not break backward compatibility.
Design:
Every new alias added will create its own
<alias>.mixfile in order for the IS to find it.Future work:
This is a non efficient way to use aliases as every different alaises regarding the same SH will load dynamically the same library separatly.
Neverthwless, any other way to implement it will cost too much effort and will change the main logic of the core.
Signed-off-by: jparisu javierparis@eprosima.com