Skip to content

Comments

Fix null error on removing children#20

Open
jakeane wants to merge 2 commits intoeberhara:masterfrom
jakeane:fix-undefined-ref
Open

Fix null error on removing children#20
jakeane wants to merge 2 commits intoeberhara:masterfrom
jakeane:fix-undefined-ref

Conversation

@jakeane
Copy link

@jakeane jakeane commented Jul 22, 2021

Discovered issue when children are removed from the component. Results in this error

Uncaught TypeError: Cannot read property 'offsetTop' of null
    at _default._this.handleVerticalScroll (component.js:72)
    at _this.handleScroll (component.js:94)

Now null checks are performed in the problematic sections. This will avoid an error being raised unnecessarily.

Also, I removed the engine requirements, as they seem inconsequential.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant