Conversation
laisecf
approved these changes
Aug 12, 2025
Collaborator
laisecf
left a comment
laisecf
left a comment
There was a problem hiding this comment.
I can't find a reason to keep it so strict too, so LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally, PANTHER models were searched without the
--domE 0.00000001 --incdomE 0.00000001filters. These were added seven years ago (35ae86e). Not sure why.The current procedure for PANTHER is to first identify the best homologous family (using
hmmsearch), then graft the sequence in the best location of a phylogenetic tree (usingEPA-ng).For the first step, I don't think we need to be overly strict, so this PR drops the e-value filtering. A corresponding PR for InterProScan 5 drops it as well (ebi-pf-team/interproscan#416)