EDS plugin filling Koha logs with needless warnings #53#54
Open
minusdavid wants to merge 1 commit intoebsco:masterfrom
Open
EDS plugin filling Koha logs with needless warnings #53#54minusdavid wants to merge 1 commit intoebsco:masterfrom
minusdavid wants to merge 1 commit intoebsco:masterfrom
Conversation
For the most part, these are warnings about the experimental use of given/when. Koha doesn't use given/when for this reason, and there have been patches to remove its use in the past: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479 I thought there was a line in Koha's coding guidelines but I haven't found it. It might be one of those things which is implicitly understood in the Koha community but isn't recorded explicitly anywhere. This patch removes the use of given/when in eds-methods.pl and replaces it with if statements.
Contributor
Author
|
This pull request is to address #53 |
Contributor
Author
|
Note that I've only performed a syntax check using "perl -c". I haven't actually tested this code myself. At a glance, it looks like it should work, but the maintainer should test it first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the most part, these are warnings about the experimental use
of given/when.
Koha doesn't use given/when for this reason, and there have been
patches to remove its use in the past:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11478
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11479
I thought there was a line in Koha's coding guidelines but I
haven't found it. It might be one of those things which is
implicitly understood in the Koha community but isn't recorded
explicitly anywhere.
This patch removes the use of given/when in eds-methods.pl and
replaces it with if statements.