Merged
Conversation
Owner
|
The code for this was always awkward.. 😬 |
ebullient
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started out as a simple addition but ballooned a little after some testing and catching edge cases. It works but may not be the cleanest or most efficient implementation. I didn't create an issue for this because I wasn't sure if it's correcting unintended behavior. If it isn't, I'll close this PR.
Summarized Changes
appendIntroText()toClassFeatureto handle the first "feature" entry for subclassesappendIntroText()injects a## Subclass Featuresheader between the fluff and the first real featureheadingtonullin calls toJsonSource.appendToText(){@language Name|Source|DisplayText}like{@language Primordial||Aquan}Testing and Examples
Domain Spells in Nature Domain 2014 subclass
Before:
After:
Entries in College of Valor 2024 subclass
Before:
After:
Languages in Storm Sorcery subclass
Before:
After: