Conversation
This comment was marked as outdated.
This comment was marked as outdated.
bhufmann
requested changes
Mar 1, 2024
Contributor
bhufmann
left a comment
There was a problem hiding this comment.
A lot of features went in since 0.2.0 release. So, I think this should be a minor release to 0.3.0 instead of 0.2.1.
af5602d to
5fa844e
Compare
Contributor
Author
|
The following 1 GitHub releases will be created once this pull request got merged. Release v0.3.0 with changes since v0.0.0
|
Contributor
Author
Updated. I kept the branch name the same, but that should only visible in the PR. |
Contributor
Author
|
Afterwards I can manually create a GitHub release for the couple of earlier versions (v0.1.0, v0.2.0), and move there the relevant part of the automatically generated release notes. |
bhufmann
approved these changes
Mar 1, 2024
Contributor
bhufmann
left a comment
There was a problem hiding this comment.
Looks good to me. Go release! Thanks
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trigger a release (v0.3.0) to confirm our automated release/publish infrastructure is working as intended. This was done following these instructions (README.md)
Upon merging this PR, we expect:
v0.3.0GitHub release is created, with associated release notes (auto-generated)v0.3.0git tag is createdtimeline-chart@0.3.0package is published to npm