Remove forked jdt projects#12050
Merged
tsmaeder merged 1 commit intoeclipse-che:masterfrom Nov 27, 2018
Merged
Conversation
tsmaeder
added
status/code-review
vparfonov
approved these changes
Nov 26, 2018
Contributor
|
@tsmaeder is this eclipse-che/che-lib#108 something that you are going to merge in master too? |
Contributor
Author
If I ever have time, I might get back to that one, but let's stick to discussing this PR here. |
Signed-off-by: Thomas Mäder <tmader@redhat.com>
tsmaeder
force-pushed
the
11926_remove_jdt
branch
from
caaf9a1 to
99b16d1
Compare
Contributor
What if not? Am I understand correctly. If after this pr these modules are not used we can remove it?
|
benoitf
removed
the
status/code-review
|
Love this kind of PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Deletes forked code from Eclipse jdt which is not in use since we've moved to jdt.ls
What issues does this PR fix or reference?
Remove JDT projects #11926