feat: add a tool to sync LyoD models from RDF by berezovskyi · Pull Request #866 · eclipse-lyo/lyo

berezovskyi · 2025-12-28T01:49:15Z

I mainly needed such a tool for the SysML/KerML v2 vocab and shape sync/conversion but I think it should be useful for the main project and it is a good place to serve as the tool's home.

In this PR, I ran the sync on:

Core, AM, CM, QM, RM domain vocabs
CM domain shapes

Other changes:

Update the CM shapes domain prefix
Update the CM shapes domain namespace

Checklist

This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
This PR was tested on at least one Lyo OSLC server (comment @oslc-bot /test-all if not sure) or adds unit/integration tests.
This PR does NOT break the API
Lint checks pass (run mvn package org.openrewrite.maven:rewrite-maven-plugin:run spotless:apply -DskipTests -P'!enforcer' if not, commit & push)

berezovskyi · 2025-12-28T15:34:10Z

@oslc-bot /test-all

oslc-bot · 2025-12-28T15:34:28Z

Downstream Build Status

Repository	Lyo CI	Job state	Workflow
`oslc-op/refimpl`	✅ Pass	`completed`	Link
`oslc/lyo-samples`	✅ Pass	`completed`	Link
`oslc/promcode-lyo-server`	✅ Pass	`completed`	Link

berezovskyi · 2025-12-28T15:42:29Z

@oslc-bot /test-all

oslc-bot · 2025-12-28T15:42:33Z

Downstream Build Status

Repository	Lyo CI	Job state	Workflow
`oslc-op/refimpl`	🔴 Fail	`completed`	Link
`oslc/lyo-samples`	✅ Pass	`completed`	Link
`oslc/promcode-lyo-server`	✅ Pass	`completed`	Link

Copilot

Pull request overview

This PR adds a Python-based tool (lyo-model-sync) to synchronize RDF vocabularies and OSLC shapes with Lyo Designer model XML files. The changes also include regenerated domain classes with updated constants and imports reflecting corrections from the sync tool.

Key changes:

New Python model-sync tool with CLI for syncing RDF vocabularies and shapes
Refactored Change Management domain constants from Oslc_cmDomainConstants to Oslc_cm_shapesDomainConstants
Updated OSLC Core vocabulary constants with additional resource types
Corrected property definitions to use OsclVocabularyConstants.OSLC_CORE_NAMSPACE instead of OslcDomainConstants.OSLC_NAMSPACE

Reviewed changes

Copilot reviewed 81 out of 84 changed files in this pull request and generated 44 comments.

Show a summary per file

File	Description
domains/model-sync/*	New Python tool for syncing RDF vocabularies/shapes to Lyo Designer XML models
domains/oslc-domains/src/main/java/org/eclipse/lyo/oslc/domains/cm/*	Refactored CM domain to use `Oslc_cm_shapesDomainConstants` with correct namespace URI
domains/oslc-domains/src/main/java/org/eclipse/lyo/oslc/domains/OsclVocabularyConstants.java	Added OSLC Core resource type constants
domains/oslc-domains/src/main/java/org/eclipse/lyo/oslc/domains/*/package-info.java	Updated Lyo Designer generation timestamps
domains/org.eclipse.lyo.tools.domainmodels/*.xml	Updated vocabulary and domain specification XML with synced RDF data
pom.xml	Updated google-java-format version from 1.27.0 to 1.28.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-28T15:47:30Z

domains/oslc-domains/src/main/java/org/eclipse/lyo/oslc/domains/am/Resource.java

@@ -592,7 +597,7 @@ public void setTitle(final String title) {

  // Start of user code setterAnnotation:type
  // End of user code


This method overrides IResource.setType; it is advisable to add an Override annotation.

Suggested change

// End of user code

// End of user code

@Override

Copilot · 2025-12-28T15:47:30Z

domains/oslc-domains/src/main/java/org/eclipse/lyo/oslc/domains/am/Resource.java

  @OslcOccurs(Occurs.ZeroOrMany)
-  @OslcValueType(ValueType.String)
+  @OslcValueType(ValueType.Resource)
  @OslcReadOnly(false)


This method overrides IResource.getType; it is advisable to add an Override annotation.

Suggested change

@OslcReadOnly(false)

@OslcReadOnly(false)

@Override

Copilot · 2025-12-28T15:47:30Z

domains/oslc-domains/src/main/java/org/eclipse/lyo/oslc/domains/am/Resource.java

@@ -193,7 +196,7 @@ public void addCreator(final Link creator) {
    this.creator.add(creator);
  }



This method overrides IResource.addType; it is advisable to add an Override annotation.

Suggested change

@Override

Copilot · 2025-12-28T15:47:31Z

domains/oslc-domains/src/main/java/org/eclipse/lyo/oslc/domains/cm/ChangeRequest.java

+
+  // Start of user code setterAnnotation:severity
+  // End of user code
+  public void setSeverity(final Set<Link> severity) {


This method overrides IChangeRequest.setSeverity; it is advisable to add an Override annotation.

Copilot · 2025-12-28T15:47:31Z

domains/oslc-domains/src/main/java/org/eclipse/lyo/oslc/domains/cm/ChangeRequest.java

+
+  // Start of user code setterAnnotation:relatedTestScript
+  // End of user code
+  public void setRelatedTestScript(final Set<Link> relatedTestScript) {


This method overrides IChangeRequest.setRelatedTestScript; it is advisable to add an Override annotation.

Copilot · 2025-12-28T15:47:40Z

domains/model-sync/tests/test_sync_shapes_oslc.py

@@ -0,0 +1,31 @@
+import textwrap
+from pathlib import Path


Import of 'Path' is not used.

Suggested change

from pathlib import Path

Copilot · 2025-12-28T15:47:40Z

domains/model-sync/tests/test_sync_vocab.py

@@ -0,0 +1,141 @@
+import tempfile


Import of 'tempfile' is not used.

Suggested change

import tempfile

Copilot · 2025-12-28T15:47:40Z

domains/model-sync/tests/test_sync_vocab.py

@@ -0,0 +1,141 @@
+import tempfile
+from pathlib import Path


Import of 'Path' is not used.

Suggested change

from pathlib import Path

Copilot · 2025-12-28T15:47:41Z

domains/model-sync/lyo_model_sync/sync.py

+                label = vocab.get('label')
+                if label:
+                    return label
+    except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

Copilot · 2025-12-28T15:47:41Z

domains/model-sync/lyo_model_sync/sync.py

+                for item in vocab.findall(f'.//{item_type}'):
+                    if item.get('name') == item_name:
+                        return True
+    except Exception:


'except' clause does nothing but pass and there is no explanatory comment.

berezovskyi added 4 commits December 28, 2025 02:47

feat: add a tool to sync LyoD models from RDF

26b9141

gen: sync am/cm/qm/rm vocabs

e87956a

fix: set the description of archaic props to "archaic"

8de8004

chore: resave with LyoD

8d41f4b

berezovskyi requested a review from Jad-el-khoury December 28, 2025 02:08

berezovskyi added 5 commits December 28, 2025 13:06

domain: fix CM shape NS and prefix

f5f1ff6

fix: shape sync

2ee0a92

fix: revert shapes

c444ffc

fix: revert shapes but keep ns changes

eafd193

feat: gen CM shapes for LyoD

c5aa71b

berezovskyi added this to the 7.0 milestone Dec 28, 2025

chore: cleanup

e5da719

berezovskyi marked this pull request as ready for review December 28, 2025 15:42

Copilot AI review requested due to automatic review settings December 28, 2025 15:42

Copilot started reviewing on behalf of berezovskyi December 28, 2025 15:43 View session

Copilot AI reviewed Dec 28, 2025

View reviewed changes

berezovskyi mentioned this pull request Dec 28, 2025

gen: after domains sync upstream oslc-op/refimpl#485

Open

berezovskyi and others added 6 commits December 28, 2025 18:21

fix: workaround for refimpl

2e85368

Merge branch 'master' into b-domain-sync

fd041ef

Merge branch 'master' into b-domain-sync

d0f5ea7

Merge branch 'master' into b-domain-sync

1999696

Merge branch 'master' into b-domain-sync

8b7a8e9

Merge branch 'master' into b-domain-sync

aec1bbb

		@@ -592,7 +597,7 @@ public void setTitle(final String title) {

		// Start of user code setterAnnotation:type
		// End of user code

		@@ -193,7 +196,7 @@ public void addCreator(final Link creator) {
		this.creator.add(creator);
		}

Conversation

berezovskyi commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

berezovskyi commented Dec 28, 2025

Uh oh!

oslc-bot commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Downstream Build Status

Uh oh!

berezovskyi commented Dec 28, 2025

Uh oh!

oslc-bot commented Dec 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Downstream Build Status

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

berezovskyi commented Dec 28, 2025 •

edited

Loading

oslc-bot commented Dec 28, 2025 •

edited

Loading

oslc-bot commented Dec 28, 2025 •

edited

Loading