issue-13: protect review dog against stray xml#15
Closed
Conversation
alexmohr
force-pushed
the
bugfix/xml
branch
4 times, most recently
from
fc457d3 to
559eea2
Compare
remove <, > from output to prevent breaking the xml parser of reviewdog Signed-off-by: Alexander Mohr <alexander.m.mohr@mercedes-benz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If rustfmt produces output that contains <, > i.e. if a line is too long and contains such a char,
reviewdog will fail to parse this because the input is into reviewdog is not sanitized.
To address this 'diff' in a worktree is used instead using the raw rustfmt output
Checklist
Related
Notes for Reviewers
Alexander Mohr alexander.m.mohr@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information