Skip to content

ADR: add rust linting & formatting ADR proposal#80

Open
theswiftfox wants to merge 3 commits intomainfrom
theswiftfox/adr_rust_style
Open

ADR: add rust linting & formatting ADR proposal#80
theswiftfox wants to merge 3 commits intomainfrom
theswiftfox/adr_rust_style

Conversation

@theswiftfox
Copy link

@theswiftfox theswiftfox commented Feb 6, 2026

Summary

Add an ADR regarding rust linter & formatting rules.
Outcome TBD before merging.

Notes for Reviewers

Feel free to add suggestions or propose a third option to be decided in the architecture meeting.


Elena Gantner elena.gantner@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information

Signed-off-by: Elena Gantner <elena.gantner@mercedes-benz.com>
@alexmohr
Copy link

alexmohr commented Feb 9, 2026

Related suggestion: Once we agree on these rules they can be put into the CICD repository, to enable re-use. Furhtermore the CICD repo can offer a check to validate them and leave comments via reviewdog, similar to what we did in the CDA here

Signed-off-by: Elena Gantner <elena.gantner@mercedes-benz.com>
@theswiftfox
Copy link
Author

Thanks for the feedback @stmuench :)
I updated the sections (hope I didn't miss anything)


## Decision Outcome

TBD

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could update this entry now :)

nav_order: 100
title: Define common linting and formating rules for Rust in OpenSOVD

status: "proposed"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe update this entry now?

Copy link
Author

@theswiftfox theswiftfox Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will do this today! (edit: or probably tomorrow - got stuck on the CI/CD implementation for the common linting..)

Copy link

@stmuench stmuench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we maybe also mention where we will put the common definition now sow that they can be used by other repos as well?

@theswiftfox
Copy link
Author

should we maybe also mention where we will put the common definition now sow that they can be used by other repos as well?

Yes, I will update with the Note that the common definition will be found in the CI/CD repository.
I have a (draft) PR in that repo that adds the config as agreed on here and has a pre-commit check that the Cargo.toml has the lints enabled. Disclaimer: This is very much WIP and is missing any documentation for now (working on it 😅)

Signed-off-by: Elena Gantner <elena.gantner@mercedes-benz.com>
@theswiftfox theswiftfox marked this pull request as ready for review February 23, 2026 08:07
@theswiftfox theswiftfox requested a review from a team as a code owner February 23, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants