feat: initial CI/CD workflow for uds2sovd-proxy by arvindr19 · Pull Request #3 · eclipse-opensovd/uds2sovd-proxy

arvindr19 · 2026-02-25T06:22:12Z

Summary

initial CI/CD workflow for uds2sovd-proxy

Checklist

I have tested my changes locally
I have added or updated documentation
I have linked related issues or discussions
I have added or updated tests

.github/workflows/build.yml

stmuench · 2026-02-26T08:58:10Z

.github/workflows/build.yml

+    needs: format_and_clippy_nightly_toolchain_pinned
+    concurrency:
+      group: format_and_clippy_nightly_toolchain_latest-${{ github.ref }}
+    runs-on: ubuntu-latest


good for now but we should create a github issue to follow-up on this topic. since CI workflows should never depend on a latest image. imagine someone updating this and potentially breaking all CI workflow due to some potential incompatibility

Agreed. we're using ubuntu-latest and windows-latest which can introduce breaking changes. I'll create a follow-up issue.

stmuench · 2026-02-26T08:58:42Z

.github/workflows/build.yml

+    concurrency:
+      group: format_and_clippy_nightly_toolchain_latest-${{ github.ref }}
+    runs-on: ubuntu-latest
+    continue-on-error: true


really? why not fail fast? that would save resources (which are expensive)

addressed, used fast-fail

.github/workflows/build.yml

stmuench · 2026-02-26T10:02:00Z

deny.toml

+[graph]
+targets = [
+  "aarch64-unknown-linux-gnu",
+  "aarch64-apple-darwin",


really required?

Added TODO, BTW which platform we support officially?

for OpenSOVD, I must admit I cannot say. For S-CORE, however, we actually need aarch64-qnx-nto-gnu

Kept targets and Added TODO, will update once we know which platforms are supported.

I would disagree here. Please remove especially such one until we know exactly that we really need to support it.

stmuench · 2026-02-26T10:02:48Z

deny.toml

+# List of explicitly allowed licenses
+# See https://spdx.org/licenses/ for list of possible licenses
+# [possible values: any SPDX 3.11 short identifier (+ optional exception)].
+allow = ["Apache-2.0", "BSD-3-Clause", "ISC", "MIT", "Unicode-3.0", "Zlib"]


this is unexpected. we should doublecheck. I though that that only "Apache-2.0" as well as "MIT" would be allowed

As of now, we don’t need any licenses other than Apache-2.0 and MIT. However, if we use crates in the future that are licensed under something else, we’ll need to add those licenses here.

Yes, but then we must also only add such new allowed licenses here exactly at that point. So for now, let's just stick to these two ones.

Kept only 2 licenses Apache-2.0 and MIT

stmuench · 2026-02-26T10:03:07Z

deny.toml

+unknown-registry = "warn"
+unknown-git = "warn"


why not deny?

Good to know, Updated to deny

stmuench · 2026-02-26T10:03:39Z

deny.toml

+  "https://github.com/alexmohr/aide.git",
+  "https://github.com/alexmohr/flatbuffers.git",


please add comments that these are subject to be clarified and/or removed

Added TODO as comment

stmuench · 2026-02-26T10:04:55Z

CODESTYLE.md

+]
+```
+
+## Imports


add newline after for consistency

stmuench · 2026-02-27T09:22:04Z

.github/workflows/build.yml

+      - name: Install Rust toolchain
+        uses: dtolnay/rust-toolchain@master
+        with:
+          toolchain: 1.88.0


please also create a follow-up issue that this property/setting must get consumed via cicd-workflows repo

created issue #6

stmuench · 2026-02-27T09:23:20Z

.github/workflows/pr-checks.yml

+      - name: Checkout repository
+        uses: actions/checkout@v4
+        with:
+          submodules: false


so clippy really does not need any deps of the code it checks?

No separate dependency fetch step is needed: cargo clippy is a semantic linter that requires compiled dependencies.
Cargo automatically resolves, downloads, and compiles all crates from the registry as part of the clippy invocation, no explicit cargo fetch step is require

thanks for clarifying :)

stmuench · 2026-02-27T09:24:00Z

.github/workflows/pr-checks.yml

+      - name: Format and Clippy - Nightly toolchain latest
+        uses: eclipse-opensovd/cicd-workflows/rust-lint-and-format-action@f829f9a9b93129170b25ae6769985ddff14fd252
+        with:
+          toolchain: nightly
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          fail-on-format-error: "false"
+          fail-on-clippy-error: "false"
+          clippy-deny-warnings: "false"


why this duplicated workflow?

This step is intentionally non-blocking (all fail-on-* are "false") it provides early visibility into upcoming nightly breakage so issues can be fixed before the pinned toolchain is updated.

So what would be the benefit for devs' PRs? So what would they do? Fix stuff proactively, is that the rationale?

IMO Yes, proactive fixing is exactly the rationale. The non-blocking nightly step acts as an early warning system. When a developer opens a PR, they immediately see without any extra effort, whether their code is on a collision course with an upcoming nightly toolchain change. They can choose to fix it then and there, while the context is fresh, rather than being surprised later

stmuench · 2026-02-27T09:28:33Z

deny.toml

+[graph]
+targets = [
+  "aarch64-unknown-linux-gnu",
+  "aarch64-apple-darwin",


I would disagree here. Please remove especially such one until we know exactly that we really need to support it.

stmuench · 2026-02-27T09:28:57Z

deny.toml

+# [possible values: any SPDX 3.11 short identifier (+ optional exception)].
+allow = ["Apache-2.0", "MIT"]
+
+confidence-threshold = 0.8


what is this property about?

Minimum confidence score (0.0-1.0) for license detection heuristics.
cargo-deny uses text similarity to detect licenses when an SPDX identifier is absent. 0.8 means the detected license must match the known template at 80% similarity before it is accepted. Values below this threshold are treated as unknown and denied.

hmm, then let's maybe start with 0.9 instead and lower the value if really required at some point?

stmuench

Can we somehow invoke these new workflow manually for this PR? To be sure that they are actually working here in github?

arvindr19 · 2026-02-27T13:24:52Z

Can we somehow invoke these new workflow manually for this PR? To be sure that they are actually working here in github?
Explored couple of options, nothing worked.
workflow_dispatch requires the workflow file to exist on the repo's default branch (main). Both the upstream and fork have an empty main, the workflows only exist on fork repo's feature/initial-implementation.
The only fix I think is to merge this PR first. Once these files land on main, every subsequent PR will automatically trigger them.

feat: initial CI/CD workflow for uds2sovd-proxy

04dfc15

arvindr19 force-pushed the feature/initial-implementation branch from 79ffa38 to 04dfc15 Compare February 25, 2026 06:25

arvindr19 marked this pull request as draft February 25, 2026 06:28

arvindr19 changed the title ~~feat: initial uds2sovd-proxy implementation with CI/CD~~ feat: initial CI/CD workflow for uds2sovd-proxy Feb 25, 2026

arvindr19 and others added 3 commits February 25, 2026 15:55

CI/CD: add separate workflows for PR

3ad7d5e

CI/CD: remove clippy and format from rust build stage

ddc3994

CI/CD: added contributer names

6c47ea0

stmuench reviewed Feb 26, 2026

View reviewed changes

stmuench reviewed Feb 27, 2026

View reviewed changes

stmuench suggested changes Feb 27, 2026

View reviewed changes

This was referenced Feb 27, 2026

CI: Pin runner OS versions instead of using "latest" #5

Open

CI: Consume Rust toolchain version from cicd-workflows instead of hardcoding #6

Open

CI: Define officially supported target platforms for cargo-deny #7

Open

CI/CD: addressed review comments

832c05f

arvindr19 force-pushed the feature/initial-implementation branch from b088bea to 832c05f Compare February 27, 2026 10:26

stmuench approved these changes Feb 27, 2026

View reviewed changes

arvindr19 marked this pull request as ready for review February 27, 2026 13:31

		"https://github.com/alexmohr/aide.git",
		"https://github.com/alexmohr/flatbuffers.git",

		unknown-registry = "warn"
		unknown-git = "warn"

Conversation

arvindr19 commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arvindr19 Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stmuench Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stmuench left a comment

arvindr19 commented Feb 25, 2026 •

edited

Loading

arvindr19 Feb 26, 2026 •

edited

Loading

stmuench Feb 27, 2026 •

edited

Loading