BUILD for aarch64 : Suggested changes by rahulthakre29 · Pull Request #100 · eclipse-score/baselibs

rahulthakre29 · 2026-02-10T10:00:58Z

Suggested Changes to build aarch64 on Baselib

github-actions · 2026-02-10T10:07:34Z

The created documentation from the pull request is available at: docu-html

third_party/acl/BUILD

third_party/acl/acl-amd64.BUILD

BUILD

MODULE.bazel

third_party/libcap2/libcap2-amd64-dev.BUILD

4og · 2026-02-19T13:32:57Z

BUILD

+# Platform-aware library aliases for backward compatibility
+alias(
+    name = "acl",
+    actual = "//third_party/acl:acl",
+    visibility = ["//visibility:public"],
+)
+
+alias(
+    name = "libcap2",
+    actual = "//third_party/libcap2:libcap2", 
+    visibility = ["//visibility:public"],
+)
+
+alias(
+    name = "libcap2-dev",
+    actual = "//third_party/libcap2:libcap2",
+    visibility = ["//visibility:public"],
+)
+
+alias(
+    name = "libseccomp2",
+    actual = "//third_party/libseccomp2:libseccomp2",
+    visibility = ["//visibility:public"],
+)
+
+alias(
+    name = "libseccomp2-dev", 
+    actual = "//third_party/libseccomp2:libseccomp2",
+    visibility = ["//visibility:public"],
+)
+
+alias(
+    name = "valgrind",
+    actual = "//third_party/valgrind:valgrind",
+    visibility = ["//visibility:public"],
+)


There are already aliases and cc_library targets in //third-party/... Let's not have one more indirection

4og · 2026-02-19T13:34:16Z

score/concurrency/BUILD

    deps = select({
        "@platforms//os:qnx": [],
-        "//conditions:default": ["//third_party/valgrind"],
+        "//conditions:default": ["//:valgrind"],


This change is not needed. Having it refer to //third_party/valgrind is perfectly fine. Moreover, by not having this change, we'll avoid change sin our internal codebase.

4og · 2026-02-19T13:35:46Z

score/os/linux/utils/BUILD

    ],
    deps = [
-        "//third_party/libseccomp2",
+        "//:libseccomp2-dev",


Same as in the valgrind case above. Please leave deps to //third_party/... without change. Same applies to all other similar cases in this PR.

4og · 2026-02-19T13:46:55Z

third_party/acl/acl.BUILD

+        "@platforms//cpu:aarch64": ["lib/aarch64-linux-gnu/libacl.a"],
+        "//conditions:default": ["lib/x86_64-linux-gnu/libacl.a"],


lib/x86_64-linux-gnu/libacl.a is a symlink in deb archive to usr/lib/x86_64-linux-gnu/libacl.a. I would avoid extra indirection, i.e. keep usr/lib

In case of aarch64, there is no such symlink, so the build will likely to fail, i.e. add usr/ in front

You can validate AArch64 builds locally with bazel build --config=bl-aarch64-linux //score/...

4og · 2026-02-26T08:47:09Z

score/language/safecpp/test/test_std_arithmetic_types.cpp


 TEST(StdIntegralTypes, signess_and_bytes_number)
 {
-// Test identifies implementation defined behavior.


This change is not needed anymore. With last sync, it's already fixed.

- fix missing BUILD parameters for AArch64 - Correct file paths for static libraries in dev packages - Consolidate architecture specific Build file using select()

rahulthakre29 requested a deployment to workflow-approval February 10, 2026 10:01 — with GitHub Actions Waiting

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from 346bf99 to 79047c4 Compare February 10, 2026 10:09

rahulthakre29 requested a deployment to workflow-approval February 10, 2026 10:10 — with GitHub Actions Waiting

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from 79047c4 to b45bfdb Compare February 10, 2026 10:15

rahulthakre29 requested a deployment to workflow-approval February 10, 2026 10:15 — with GitHub Actions Waiting

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from b45bfdb to f8d4bb8 Compare February 10, 2026 10:25

rahulthakre29 requested a deployment to workflow-approval February 10, 2026 10:25 — with GitHub Actions Waiting

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from f8d4bb8 to 7c5e445 Compare February 10, 2026 11:01

rahulthakre29 temporarily deployed to workflow-approval February 10, 2026 11:01 — with GitHub Actions Inactive

4og requested changes Feb 10, 2026

View reviewed changes

rahulthakre29 requested a deployment to workflow-approval February 12, 2026 11:37 — with GitHub Actions Waiting

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from ffb641c to 9d7698f Compare February 12, 2026 12:07

rahulthakre29 temporarily deployed to workflow-approval February 12, 2026 12:07 — with GitHub Actions Inactive

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from 9d7698f to 4446685 Compare February 17, 2026 06:01

rahulthakre29 requested a deployment to workflow-approval February 17, 2026 06:01 — with GitHub Actions Waiting

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from 4446685 to c8d2343 Compare February 18, 2026 05:27

rahulthakre29 temporarily deployed to workflow-approval February 18, 2026 05:28 — with GitHub Actions Inactive

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from c8d2343 to 94efb57 Compare February 18, 2026 10:05

rahulthakre29 temporarily deployed to workflow-approval February 18, 2026 10:05 — with GitHub Actions Inactive

4og requested changes Feb 19, 2026

View reviewed changes

4og added this to BAS - Baselibs FT Feb 20, 2026

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from 94efb57 to 2d62379 Compare February 23, 2026 08:34

rahulthakre29 requested a deployment to workflow-approval February 23, 2026 08:34 — with GitHub Actions Waiting

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from 2d62379 to da89fdc Compare February 23, 2026 08:42

rahulthakre29 temporarily deployed to workflow-approval February 23, 2026 08:42 — with GitHub Actions Inactive

rahulthakre29 requested a deployment to workflow-approval February 24, 2026 05:54 — with GitHub Actions Waiting

rahulthakre29 temporarily deployed to workflow-approval February 24, 2026 07:59 — with GitHub Actions Inactive

4og reviewed Feb 26, 2026

View reviewed changes

4og self-requested a review February 26, 2026 08:48

rahulthakre29 added 3 commits February 27, 2026 12:31

Build aarch64: Suggested change for aarch64

4d06efc

aarch64: fix build issues

dff9410

aarch64: Fix bazle build failures

5194c4c

- fix missing BUILD parameters for AArch64 - Correct file paths for static libraries in dev packages - Consolidate architecture specific Build file using select()

rahulthakre29 force-pushed the rt/investigating_build_baselib_on_AArch64_Linux branch from a5b7196 to 5194c4c Compare February 27, 2026 07:02

rahulthakre29 requested a deployment to workflow-approval February 27, 2026 07:02 — with GitHub Actions Waiting

		"@platforms//cpu:aarch64": ["lib/aarch64-linux-gnu/libacl.a"],
		"//conditions:default": ["lib/x86_64-linux-gnu/libacl.a"],

Conversation

rahulthakre29 commented Feb 10, 2026

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants