remove unnecessary lock in SharedMemoryResource::do_deallocate#108
Open
ShoroukRamzy wants to merge 1 commit intoeclipse-score:mainfrom
Open
remove unnecessary lock in SharedMemoryResource::do_deallocate#108ShoroukRamzy wants to merge 1 commit intoeclipse-score:mainfrom
ShoroukRamzy wants to merge 1 commit intoeclipse-score:mainfrom
Conversation
|
The created documentation from the pull request is available at: docu-html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes an unnecessary
std::lock_guardfrom theSharedMemoryResource::do_deallocatemethod.Problem
The
SharedMemoryResourceimplements a monotonic (Arena) allocation strategy, wheredeallocateis a no-op. The current implementation acquires a heavyweightInterprocessMutexbefore doing nothing, which introduces unnecessary performance overhead on every deallocation call.Solution
The
std::lock_guardis removed from the function. Since no shared state is read or modified, no lock is required.Benefits