Enhance C++ coverage reusable workflow#65
Conversation
.github/workflows/cpp-coverage.yml
Outdated
| uses: bazel-contrib/setup-bazel@0.18.0 | ||
| with: | ||
| disk-cache: ${{ github.workflow }} | ||
| disk-cache: ${{ format('{0}_{1}', github.workflow, github.ref_name) }} |
There was a problem hiding this comment.
@PiotrKorkus shall we just do a cache only for main really? any other seems to cache polution.
There was a problem hiding this comment.
yes, as we talked already.
Caching only main should be sufficient, PRs should still benefit in some scope from it
There was a problem hiding this comment.
Keep this ${{ github.workflow }}
and do logic like cache-save: ${{ github.event_name == 'push' }} && ${{ github.branch== 'main' }.
Supporting multi-branch is hard i think.
.github/workflows/cpp-coverage.yml
Outdated
|
|
||
| # Note: This action writes cache config to ~/.bazelrc | ||
| # Projects must include "try-import ~/.bazelrc" in their .bazelrc to enable caching | ||
| # See: https://github.com/eclipse-score/reference_integration/blob/main/.bazelrc#L84 |
There was a problem hiding this comment.
This can go to Readme.md of this repo as attention note, @dcalavrezo-qorix what do you think ? Or shall we do checks in cicd workflows that .bazelrc does that ?
There was a problem hiding this comment.
As far as I know, bazel automatically imports .bazelrc from the home folder. I don't think any try-import is needed at all.
There was a problem hiding this comment.
just checked locally and @4og is right, ~/.bazelrc was loaded without try-import
There was a problem hiding this comment.
Seems so as per doc and tested in ref int. Then, I guess we saw other issues with cache on reference integration that overlaid with this one.
There was a problem hiding this comment.
There was a problem hiding this comment.
@RSingh1511 then You can revert what i requested and You added for this point. Sorry ;)
FScholPer
left a comment
FScholPer
left a comment
There was a problem hiding this comment.
Except the readme looks quite good
|
|
||
| --- | ||
|
|
||
| ### **8️ Copyright Check Workflow** |
There was a problem hiding this comment.
the numbers are a little bit strange ;)
github-project-automation
bot
moved this from Draft
to Done
in INF - Infrastructure Community
5 participants
No description provided.