Enable installing dependencies before running tests#68
Conversation
.github/workflows/tests.yml
Outdated
| ref: ${{ github.head_ref || github.event.pull_request.head.ref || github.ref }} | ||
| repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }} | ||
|
|
||
| - name: Install fakechroot |
There was a problem hiding this comment.
This workflow shall be removed imho, becasue we have coverage one that does the same.
There was a problem hiding this comment.
Im not sure if calling ITF / python tests wont backfire when we call it with bazel coverage. I would say its not logical to use coverage for the tests other than unit.
There was a problem hiding this comment.
at least for pytest it shouldn't be a problem, I've modified the coverage.yml to also run the smoke test on my forked repo and it doesn't seem to affect coverage: https://github.com/eelcoem/lifecycle/actions/runs/22389849106/job/64808791033
Edit: Agree it is probably best to keep the tests workflow for clearer separation
.github/workflows/tests.yml
Outdated
| ref: ${{ github.head_ref || github.event.pull_request.head.ref || github.ref }} | ||
| repository: ${{ github.event.pull_request.head.repo.full_name || github.repository }} | ||
|
|
||
| - name: Install fakechroot |
There was a problem hiding this comment.
Im not sure if calling ITF / python tests wont backfire when we call it with bazel coverage. I would say its not logical to use coverage for the tests other than unit.
.github/workflows/tests.yml
Outdated
| - name: Install fakechroot | ||
| uses: eclipse-score/apt-install@main | ||
| with: | ||
| packages: fakechroot |
There was a problem hiding this comment.
not everyone needs this dependecy, make this step generic, allow user to provide a list of deps to install in input
eelcoem
changed the title
github-project-automation
bot
moved this from Draft
to Done
in INF - Infrastructure Community
4 participants
Partially fixes eclipse-score/lifecycle#92