Open
Conversation
Thomas-Mikhael
requested review from
LittleHuba,
castler and
hoe-jo
as code owners
| const auto& bindingValue = bindingValue_result.value().get(); | ||
| if (bindingValue == kSomeIpBinding) | ||
| { | ||
| { // TM: Here it logs fatal and aborts, while in 974 ParseServiceTypeDeployment() it just skips it |
There was a problem hiding this comment.
Maybe a more generic question: why do we need the binding twice? Once in the serviceType and once in the serviceInstance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is to discuss the current Json ConfigParser implementation