Use reuse lint instead of reuse annotate#100
Open
lurtz wants to merge 3 commits intoeclipse-score:mainfrom
Open
Use reuse lint instead of reuse annotate#100lurtz wants to merge 3 commits intoeclipse-score:mainfrom
reuse lint instead of reuse annotate#100lurtz wants to merge 3 commits intoeclipse-score:mainfrom
Conversation
FScholPer
reviewed
Feb 26, 2026
| - id: reuse lint | ||
| name: Check copyright headers with reuse lint | ||
| entry: ./scripts/run_reuse_lint.sh | ||
| language: unsupported_script |
Contributor
Author
There was a problem hiding this comment.
https://pre-commit.com/#unsupported_script
It basically tells pre-commit just to invoke a shell script without extra sandboxing.
…t line is present
annotate was never meant to be run without human intervention and reuse lint thus works more reliable
lurtz
force-pushed
the
reuse-improvements
branch
from
218c578 to
fdf05cc
Compare
Contributor
Author
|
FYI the minimum copyright header this can enforce is I now made up my mind, what the best combination of tools is. We should run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reuse annotatewas never meant to be run without human interaction and is unsuited to be run in CI environments.reuse lintis much more reliable.Some cleanup was also done for stuff not needed for
reuse lint